Skip to content

chore: tidy up headless-shell hacks#33967

Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:cleanup-headless-shell-hacks
Dec 12, 2024
Merged

chore: tidy up headless-shell hacks#33967
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:cleanup-headless-shell-hacks

Conversation

@mxschmitt
Copy link
Contributor

This addresses #33964 (comment).

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt closed this Dec 12, 2024
@mxschmitt mxschmitt reopened this Dec 12, 2024
@mxschmitt mxschmitt force-pushed the cleanup-headless-shell-hacks branch 2 times, most recently from d2ceeb0 to 74da212 Compare December 12, 2024 19:02
@github-actions

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the cleanup-headless-shell-hacks branch from 74da212 to 3dc9aeb Compare December 12, 2024 19:07
@mxschmitt mxschmitt force-pushed the cleanup-headless-shell-hacks branch from 3dc9aeb to 54efe7b Compare December 12, 2024 19:07
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:368:5 › launchServer › should reject waitForSelector when browser closes @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37247 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 38758c0 into microsoft:main Dec 12, 2024
@mxschmitt mxschmitt deleted the cleanup-headless-shell-hacks branch December 12, 2024 20:23
@pkoenig10
Copy link

pkoenig10 commented Feb 5, 2025

Would you consider reverting this change?

We have a script that mirrors the Playwright artifacts into our own internal repo (so we don't put load on and rely on the Azure CDNs in our CI). We use browsers.json to know which artifacts/versions are required by the latest version of Playwright. By moving this out of browsers.json, browsers.json is no longer a complete source of "what artifacts/versions does Playwright require?"

I certainly could update my script, but I'd prefer not to have to port all the logic that may be introduced here just to know which artifacts to download. Given that browsers.json is generated, it seems better to keep this logic in roll_browser.js so that browsers.json is an authoritative source of this information.

I've put up a PR in #34636.

If there is a better way for us to collect the list of artifacts/versions Playwright uses, I'd be happy to update our script.

pkoenig10 added a commit to pkoenig10/playwright that referenced this pull request Feb 5, 2025
@agg23
Copy link
Contributor

agg23 commented Feb 6, 2025

@pkoenig10, browsers.json is not part of our public API and we do not condone this use. See a similar issue from last week: #34508 (comment)

mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Feb 6, 2025
@agg23
Copy link
Contributor

agg23 commented Feb 11, 2025

We have ended up reverting the change for browsers.json. We still do not condone relying on this file, but until we provide a more suitable API, we will unblock you. This will release with v1.51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants